This repository was archived by the owner on Sep 16, 2021. It is now read-only.
fixed address tests for litecoin and new P2SH format#6
Open
jwsher wants to merge 1 commit intolitecore-archive:masterfrom
Open
fixed address tests for litecoin and new P2SH format#6jwsher wants to merge 1 commit intolitecore-archive:masterfrom
jwsher wants to merge 1 commit intolitecore-archive:masterfrom
Conversation
Closed
|
Fixed in #15, pending merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests run via
npm testwere not passing. This was caused due to most addresses not being Litecoin testnet addresses. There were also older P2SH Litecoin addresses that started with a '3'.I converted the addresses starting with a '3' to new P2SH addresses using the instructions here : https://blog.trezor.io/litecoins-new-p2sh-segwit-addresses-843633e3e707 .
I replaced the Bitcoin testnet address with the Litecoin testnet address from http://testnet.litecointools.com/
All the tests pass now.